saving the pub should come outside the find_or_create_by block (#1053)

saving the pub should come outside the find_or_create_by block

app/models/author.rb

@@ -171,9 +171,9 @@ def assign_pub(pub)
         cap_profile_id: cap_profile_id,
         featured: false, status: 'new', visibility: 'private'
       )
-      pub.pubhash_needs_update! # Add to pub_hash[:authorship]
-      pub.save! # contrib.save! not needed
     end
+    pub.pubhash_needs_update! # Add to pub_hash[:authorship]
+    pub.save! # contrib.save! not needed
   end
 
   private

spec/factories/publication.rb

@@ -52,4 +52,16 @@
              identifier_value: '10048354')
     end
   end
+
+  factory :publication_without_author, parent: :publication do
+    pub_hash do
+      {
+        title: title,
+        type: publication_type,
+        year: year,
+        author: [],
+        authorship: []
+      }
+    end
+  end
 end

spec/models/author_spec.rb

@@ -177,4 +177,22 @@
       expect(subject).not_to be_harvestable
     end
   end
+
+  describe '#assign_pub' do
+    let(:pub) { create :publication_without_author }
+
+    it 'creates contrib and updates pubhash' do
+      expect(subject.publications.count).to eq(0)
+      expect(subject.contributions.count).to eq(0)
+      expect(Publication.find(pub.id).pub_hash[:authorship].length).to eq(0)
+
+      subject.assign_pub(pub)
+      expect(subject.publications.count).to eq(1)
+      expect(subject.contributions.count).to eq(1)
+
+      # Verify that author added to publication
+      # See https://github.com/sul-dlss/sul_pub/issues/1052
+      expect(Publication.find(pub.id).pub_hash[:authorship].length).to eq(1)
+    end
+  end
 end