Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force image placement for new theme #804

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jun 5, 2024

Q A
License MIT

What's in this PR?

Force image placement for new theme.

Why?

Sphinx theme changed from <div class="figure"> to a <figure> tag and so broke existing theme changes.

@alexander-schranz alexander-schranz self-assigned this Jun 5, 2024
@alexander-schranz alexander-schranz removed their assignment Jun 5, 2024
@alexander-schranz alexander-schranz changed the base branch from 2.x to 1.0 June 5, 2024 09:14
@Prokyonn Prokyonn merged commit 5f4aab0 into sulu:1.0 Jun 5, 2024
1 check passed
@alexander-schranz alexander-schranz deleted the bugfix/image-snippets branch June 5, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants