support signing empty param values, e.g. 's.q=' #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long as an empty value for a param (e.g., s.q) is legal, we should support signing it. Current implementation simply drops params with empty values, which without reporting back to the caller, results in invalid auth headers. This should also be supported because in practice, sometimes having a parameter key present with an empty value can differ semantically from having no value explicitly specified for that parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as an empty value for a param (e.g.,
s.q=) is legal, we should support signing it. Current implementation simply drops params with empty values, which without reporting back to the caller, results in invalid auth headers. This should also be supported because in practice, sometimes having a parameter key present with an empty value can differ semantically from having no value explicitly specified for that parameter.I believe this implementation is backward-compatible, and should support different ways of handling blank and nil params.