Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make constructor return concrete type #44

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Make constructor return concrete type #44

merged 1 commit into from
Feb 27, 2024

Conversation

sunboyy
Copy link
Owner

@sunboyy sunboyy commented Feb 27, 2024

Refer to #42

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (4992f43) to head (d7e15f7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files          27       27           
  Lines        1345     1346    +1     
=======================================
+ Hits         1310     1311    +1     
  Misses         20       20           
  Partials       15       15           
Flag Coverage Δ
unittests 97.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunboyy sunboyy merged commit 7bb44ba into main Feb 27, 2024
5 checks passed
@sunboyy sunboyy deleted the return-concrete branch February 27, 2024 15:23
@hhow09
Copy link
Contributor

hhow09 commented Feb 27, 2024

might also need to update examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants