Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move e2e generation logic to internal/generation #50

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

sunboyy
Copy link
Owner

@sunboyy sunboyy commented May 17, 2024

No description provided.

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 93.49%. Comparing base (0c72075) to head (b8cb9e7).

Files Patch % Lines
main.go 0.00% 10 Missing ⚠️
internal/generator/generator.go 80.48% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #50       +/-   ##
===========================================
+ Coverage   77.50%   93.49%   +15.99%     
===========================================
  Files          30       23        -7     
  Lines        1840     1506      -334     
===========================================
- Hits         1426     1408       -18     
+ Misses        394       79      -315     
+ Partials       20       19        -1     
Flag Coverage Δ
unittests 93.49% <64.70%> (+15.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunboyy sunboyy merged commit c49ddcc into main May 17, 2024
3 of 5 checks passed
@sunboyy sunboyy deleted the e2e-generation branch May 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant