Seperated the tcp host and port for tcp socket #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…will need a seperate host env var
sunspikes
reviewed
May 18, 2022
| |-------------------------------------------------------------------------- | ||
| | TCP Port | ||
| |-------------------------------------------------------------------------- | ||
| | This option defines the TCP host to the ClamAV instance. |
There was a problem hiding this comment.
"This option defines the TCP socket port to the ClamAV instance."
sunspikes
reviewed
May 18, 2022
|
|
||
| /* | ||
| |-------------------------------------------------------------------------- | ||
| | TCP Port |
sunspikes
reviewed
May 18, 2022
| |-------------------------------------------------------------------------- | ||
| | TCP Host | ||
| |-------------------------------------------------------------------------- | ||
| | This option defines the TCP host to the ClamAV instance. |
There was a problem hiding this comment.
"This option defines the TCP socket host to the ClamAV instance."
sunspikes
reviewed
May 18, 2022
|
|
||
| /* | ||
| |-------------------------------------------------------------------------- | ||
| | TCP Host |
|
Thank you @LGHOFMAN, may be we can improve the wordings a bit? 🤔 btw really sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since using clamav docker container, will require a seperate host env var for the host to be populated