Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to gpt-3.5-turbo #34

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

chartpath
Copy link
Contributor

Fixes #19

This worked on one of my projects.

@gregnr
Copy link
Contributor

gregnr commented Jul 6, 2023

Thanks @chartpath. For this to work we would also need to update the client right? Switching to something like useChat().

@chartpath
Copy link
Contributor Author

chartpath commented Jul 7, 2023

@gregnr Yes probably if you want full bidirectional chat like the API supports under the hood. My project is sticking with uni-directional Q&A for now, so it still works for that but allows us to use the gpt-3.5-turbo model.

EDIT: I'd also like to add that not all users want a full chat and there are many other frameworks out there which provide this. Would love if this project stayed as a minimal seed for starting new ones without imposing too many user-facing features beyond the excellent POC for vector search + context injection that it is. 🙌

@gregnr
Copy link
Contributor

gregnr commented Jul 7, 2023

Thanks for explaining - I have no problem keeping the single Q&A format. I assumed the JSON response format from the Chat API was different and incompatible with useCompletion(). I could be wrong - have you confirmed the frontend continues to work as-is with chat API + useCompletion()?

@chartpath
Copy link
Contributor Author

@gregnr Good point, but yes I can confirm that it still works, give it a shot!

Maybe that OpenAIStream() is just more flexible than expected.

Can't tell if this comment means it falls back to a "chat of 1 message" when id doesn't get passed in: https://github.com/vercel-labs/ai/blob/e86c2ecc1a810626167bfe5a827f7da1d14889c8/packages/core/shared/types.ts#L142-L144

Copy link
Contributor

@gregnr gregnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chartpath!

@gregnr gregnr merged commit 59d4a39 into supabase-community:main Jul 7, 2023
@musashi-garami
Copy link
Contributor

Thanks @chartpath ! Appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of gpt-3.5-turbo model
3 participants