Fix _save_session's default behavior #610
Open
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR fixes a bug where
client.set_session(access_token, refresh_token)
doesn't actually update the in-memory session. This can be easily seen by creating a client and callingset_session
followed byget_session
. Theset_session
call appears to work and returns a valid response, but the subsequentget_session
call returns None, revealing that the session was never set properly.As a workaround, you can set
persist_session
to False in the client options, but this shouldn't be necessary.What is the current behavior?
set_session
does not properly update the in-memory session when thepersist_session
option is True (default).This issue was closed although the bug still exists #324
What is the new behavior?
set_session
works.