Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/#133 special characters in filename #555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/storage/limits.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export async function isImageTransformationEnabled(tenantId: string) {
export function isValidKey(key: string): boolean {
// only allow s3 safe characters and characters which require special handling for now
// https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html
return key.length > 0 && /^(\w|\/|!|-|\.|\*|'|\(|\)| |&|\$|@|=|;|:|\+|,|\?)*$/.test(key)
return key.length > 0 && /^[\p{L}\p{N}\p{M}\/!.\-*'()& $@=;:+,?]+\.[\p{L}\p{N}\p{M}]+$/u.test(key)
}

/**
Expand Down
9 changes: 9 additions & 0 deletions src/test/db/storage/limits.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { isValidKey } from "@storage/limits"

describe("Testing limits", () => {
test("accept special characters as s3 object name", () => {
expect(isValidKey("望舌诊病.pdf")).toBe(true)
expect(isValidKey("ÖÄÜ.jpg")).toBe(true)
expect(isValidKey("åäö.png")).toBe(true)
})
})