Merge pull request #10 from superbrave/fixed-transaction-status-response

Fixed the transaction status response.
superbrave · Feb 26, 2020 · da7868d · da7868d
2 parents 80c8794 + 732abb5
commit da7868d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/Message/TransactionStatusResponse.php b/src/Message/TransactionStatusResponse.php
@@ -12,7 +12,10 @@ class TransactionStatusResponse extends AbstractResponse
      */
     public function isSuccessful(): bool
     {
-        return isset($this->data['statusCode']) && $this->data['statusCode'] === 200;
+        return (isset($this->data['status']) && in_array($this->data['status'], [
+            self::RESPONSE_STATUS_COMPLETED,
+            self::RESPONSE_STATUS_SETTLED,
+        ])) && (isset($this->data['statusCode']) && $this->data['statusCode'] === 200);
     }
 
     /**

diff --git a/tests/Message/TransactionStatusResponseTest.php b/tests/Message/TransactionStatusResponseTest.php
@@ -45,9 +45,10 @@ public function testResponseReturnsSuccessful(): void
         $expectedResponseBody = [
             'contractId' => 'NjRlYjM3MTctOGI1ZC00MDg4LTgxMDgtOTMyMjQ2NzVlNTM4',
             'transactionId' => '7c9cb2f4-83ce-4b10-8d5c-de230181224f',
-            'statusCode' => 200,
+            'status' => 'COMPLETED',
             'transactionStatusDetails' => '',
             'acquirerTransactionId' => '',
+            'statusCode' => 200,
         ];
 
         $this->assertTrue($response->isSuccessful());

diff --git a/tests/Mocks/TransactionStatusSuccess.json b/tests/Mocks/TransactionStatusSuccess.json
@@ -1,7 +1,7 @@
 {
     "contractId": "NjRlYjM3MTctOGI1ZC00MDg4LTgxMDgtOTMyMjQ2NzVlNTM4",
     "transactionId": "7c9cb2f4-83ce-4b10-8d5c-de230181224f",
-    "statusCode": "COMPLETED",
+    "status": "COMPLETED",
     "transactionStatusDetails": "",
     "acquirerTransactionId": ""
 }