Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for pull requests #283

Merged
merged 4 commits into from
Jun 23, 2024
Merged

Conversation

capital-G
Copy link
Contributor

Maybe it is good to build the website on each request, just to be aware if it breaks anything.
Especially useful in combination with #282

@dyfer
Copy link
Member

dyfer commented Jun 21, 2024

Thanks @capital-G
I like the idea, but how practical is it to check the website from the raw html files? When opened locally, images etc don't get loaded so the only thing that can be checked is text, but it looks off anyway.
I wonder if there's a way to temporarily serve the website online - probably not or not a good idea anyway...

@capital-G
Copy link
Contributor Author

If you serve the directory via e.g. python3 -m http.server one can see the images, though the links are not working correctly (http://127.0.0.1:8000/projects does not get forwarded to the actual page http://127.0.0.1:8000/projects.html).

I think it is maybe less about verifying the actual website but having a build pipeline in case some dependencies must be upgraded via dependabot - but having the ability to verify some changes locally w/o building locally could still be interesting.

@dyfer
Copy link
Member

dyfer commented Jun 21, 2024

Got it. Okay, I see it being useful then.
Would you mind adding some kind of identifier (commit SHA? short SHA?) to the artifact filename? Also, the name could be more indicative than "artifact". Even if the primary use case is not the artifact, I think it would be great if it has a discerning name (with SHA).

@capital-G
Copy link
Contributor Author

Added the SHA of the commit to the artifact name. If this gets merged, it should be squashed.

@dyfer dyfer merged commit b08f750 into supercollider:main Jun 23, 2024
1 check passed
@dyfer
Copy link
Member

dyfer commented Jun 23, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants