manually drop snapshot without running its destructor #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromegn
requested changes
Jul 31, 2024
crates/corro-agent/src/agent/util.rs
Outdated
| snap.update_cleared_ts(&tx, ts) | ||
| .map_err(|source| ChangeError::Rusqlite { | ||
| source, | ||
| actor_id: None, | ||
| version: None, | ||
| })?; | ||
|
|
||
| booked.commit_snapshot(snap); |
There was a problem hiding this comment.
Running this before we know the transaction succeeds can leave the in-memory bookkeeping in a desynchornized state, compared to the database.
runsisi
force-pushed
the
wip-fix-snap
branch
2 times, most recently
from
8a9eb6d
to
cf878ad
Compare
runsisi
changed the title
this fixes the panic in debug build:
thread 'tokio-runtime-worker' panicked at crates/corro-types/src/agent.rs:1306:9:
max value was not applied
steps to reproduce:
- schema
CREATE TABLE todos (
id INTEGER NOT NULL PRIMARY KEY,
title TEXT NOT NULL DEFAULT ''
);
- node A
./corrosion -c corro.toml exec 'INSERT INTO todos (id, title) VALUES (1, "test todo")'
- node B
./corrosion -c corro.toml query 'SELECT * FROM todos'
./corrosion -c corro.toml exec 'DELETE FROM todos WHERE id == 1'
now node A crashes with assert message `max value was not applied`
Signed-off-by: runsisi <runsisi@hust.edu.cn>
jeromegn
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the panic in debug build:
thread 'tokio-runtime-worker' panicked at crates/corro-types/src/agent.rs:1306:9:
max value was not applied
steps to reproduce:
schema
CREATE TABLE todos ( id INTEGER NOT NULL PRIMARY KEY, title TEXT NOT NULL DEFAULT '' );
node A
./corrosion -c corro.toml exec 'INSERT INTO todos (id, title) VALUES (1, "test todo")'
node B
./corrosion -c corro.toml query 'SELECT * FROM todos' ./corrosion -c corro.toml exec 'DELETE FROM todos WHERE id == 1'
now node A crashes with assert message
max value was not applied