Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Fly.io example addresses with entrypoint script #37

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

catflydotio
Copy link
Contributor

@catflydotio catflydotio commented Aug 24, 2023

The old entrypoint script was setting the gossip address OK for the agent to start up, but env vars set in a script don't persist outside that script run, so then the actual address was invisible from a shell.

The fly-local-6pn line in config.toml isn't valid, so you get invalid socket address syntax trying to run a comand like corrosion reload.

This PR writes the actual 6pn address into the config file for gossip address, and puts the app name into the bootstrap address so you don't have to remember to change that from corrosion2 on deployment.

examples/fly/config.toml Outdated Show resolved Hide resolved
@catflydotio catflydotio marked this pull request as ready for review August 24, 2023 17:25
@jeromegn jeromegn merged commit 2722925 into main Aug 24, 2023
3 checks passed
@jeromegn jeromegn deleted the config-fly-example branch August 24, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants