-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: local minio to docker compose #124
Conversation
Can we add this in a separate folder instead with more examples like minio? I'd like to add this to the docs someday too. Know that I'm rewriting the documentation (pending PR here: #109) where I'd like to add these different options besides managed S3. |
Thank you, before I merge this, shall we be better off adding the actual env values to the minio docker-compose file instead as opposed to creating a new minio.env file? Can we also remove the README.md changes? I'll take this up in the docs instead and keep the README rather compact. |
The purpose of adding new minio.env file is that if you choose to use another object storage and mix with another docker-compose file instead of MinIO, just give in the run command the other env file. Like --env-file s3.env. If you take a look at docker-compose.yml file, you can see the environment was defined like this: Do you have any idea? It's no good if we pass the default values of MinIO to these environment variables |
f54ffef
to
8f9e5e8
Compare
Reverted |
Perfect, lgtm! Thank you for contributing. |
More easier for new comers to work with local configured MinIO instead of the whole AWS S3 things