Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: local minio to docker compose #124

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

ntheanh201
Copy link
Contributor

More easier for new comers to work with local configured MinIO instead of the whole AWS S3 things

@matvp91
Copy link
Collaborator

matvp91 commented Nov 22, 2024

Can we add this in a separate folder instead with more examples like minio?

I'd like to add this to the docs someday too. Know that I'm rewriting the documentation (pending PR here: #109) where I'd like to add these different options besides managed S3.

@ntheanh201
Copy link
Contributor Author

Can we add this in a separate folder instead with more examples like minio?

I'd like to add this to the docs someday too. Know that I'm rewriting the documentation (pending PR here: #109) where I'd like to add these different options besides managed S3.

@matvp91 I updated the docker compose file

@matvp91
Copy link
Collaborator

matvp91 commented Nov 26, 2024

Thank you, before I merge this, shall we be better off adding the actual env values to the minio docker-compose file instead as opposed to creating a new minio.env file?

Can we also remove the README.md changes? I'll take this up in the docs instead and keep the README rather compact.

@ntheanh201
Copy link
Contributor Author

ntheanh201 commented Nov 26, 2024

Thank you, before I merge this, shall we be better off adding the actual env values to the minio docker-compose file instead as opposed to creating a new minio.env file?

The purpose of adding new minio.env file is that if you choose to use another object storage and mix with another docker-compose file instead of MinIO, just give in the run command the other env file. Like --env-file s3.env. If you take a look at docker-compose.yml file, you can see the environment was defined like this:
- S3_ENDPOINT=${S3_ENDPOINT}
- S3_REGION=${S3_REGION}
- S3_ACCESS_KEY=${S3_ACCESS_KEY}
- S3_SECRET_KEY=${S3_SECRET_KEY}
- S3_BUCKET=${S3_BUCKET}

Do you have any idea? It's no good if we pass the default values of MinIO to these environment variables

@ntheanh201
Copy link
Contributor Author

ntheanh201 commented Nov 26, 2024

Can we also remove the README.md changes? I'll take this up in the docs instead and keep the README rather compact.

Reverted

@matvp91
Copy link
Collaborator

matvp91 commented Nov 26, 2024

Perfect, lgtm! Thank you for contributing.

@matvp91 matvp91 merged commit 5a954a8 into superstreamerapp:main Nov 26, 2024
3 checks passed
@ntheanh201 ntheanh201 deleted the feat/local_minio branch November 26, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants