Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't understand why trainExamplesHistory is not cleared between iterations #251

Open
Racines opened this issue Sep 8, 2021 · 1 comment

Comments

@Racines
Copy link

Racines commented Sep 8, 2021

Hello,

I see that the trainExamplesHistory in the Coach.py is never cleared, even when we accept a new model after the pit (line 126).
I don't understand why we are keeping the previous training data, where the stored policy (pi) and result value (v) will not be the same if evaluated by the new model.
It looks like we are continuing to train the new model with deprecated data.

Can someone explain the reason why?

@Racines Racines changed the title I don't understand why trainExamplesHistory is not clear between iterations I don't understand why trainExamplesHistory is not cleared between iterations Sep 8, 2021
@yunjiangster
Copy link

Using data from earlier iteration could help smooth the training progress and add more diversity, since the earlier models may be only slightly suboptimal compared to the most recent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants