feat(SNP-1314): Down by Maintenance #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadhorsephile
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 26.39% 26.39%
=======================================
Files 55 55
Lines 917 917
=======================================
Hits 242 242
Misses 675 675 ☔ View full report in Codecov by Sentry. |
dzmitry-struk-surf
requested changes
May 15, 2024
lib/features/down_by_maintenance/domain/services/check_server_status_service.dart
Outdated
Show resolved
Hide resolved
lib/features/down_by_maintenance/domain/services/check_server_status_service.dart
Outdated
Show resolved
Hide resolved
lib/features/down_by_maintenance/data/services/fb_check_server_status_service.dart
Outdated
Show resolved
Hide resolved
lib/features/down_by_maintenance/data/services/mock_check_server_status_service.dart
Outdated
Show resolved
Hide resolved
lib/features/down_by_maintenance/presentation/down_by_maintenance_widget.dart
Outdated
Show resolved
Hide resolved
lib/features/down_by_maintenance/presentation/down_by_maintenance_widget.dart
Outdated
Show resolved
Hide resolved
lib/features/down_by_maintenance/presentation/down_by_maintenance_wm.dart
Outdated
Show resolved
Hide resolved
lib/features/down_by_maintenance/presentation/down_by_maintenance_wm.dart
Outdated
Show resolved
Hide resolved
lib/features/down_by_maintenance/presentation/down_by_maintenance_wm.dart
Outdated
Show resolved
Hide resolved
…-template into SNP-1314-down-by-maintenance
plasticfiresam
suggested changes
May 29, 2024
Comment on lines
+50
to
+57
| // TODO(init-project): In order to use Down For Maintenance feature you have to: | ||
| // - create implementation of [ICheckServerStatusRepository] here | ||
| // - call [ICheckServerStatusRepository.configure] and await for it | ||
| // - call [ICheckServerStatusRepository.initImmediateCheck] | ||
| // - add it to AppScope | ||
| // - add DownForMaintenanceWidget in builder of MaterialApp in app.dart | ||
| // Otherwise just delete this. | ||
|
|
There was a problem hiding this comment.
It is worth putting information about this also in the documentation in the repository itself, and provide link to the documentation here
| void initImmediateCheck(); | ||
|
|
||
| /// Method that configurate service. For example, you can configurate interval of requests. | ||
| Future<void> configurate(); |
There was a problem hiding this comment.
configure() would be a more appropriate name
| void initImmediateCheck(); | ||
|
|
||
| /// Method that configurate service. For example, you can configurate interval of requests. | ||
| Future<void> configurate(); |
There was a problem hiding this comment.
configure() would be a more appropriate name
Comment on lines
+11
to
+33
| Future<void> configurate() async { | ||
| /// Here you can configurate your Firebase Remote Config interval of requests for example. | ||
| /// For example: | ||
| // | ||
| // await remoteConfig.setConfigSettings(RemoteConfigSettings( | ||
| // fetchTimeout: const Duration(minutes: 1), | ||
| // minimumFetchInterval: const Duration(hours: 1), | ||
| // )); | ||
| // | ||
| } | ||
|
|
||
| @override | ||
| Future<void> initImmediateCheck() async { | ||
| /// Here you can make a request to your Firebase Remote Config to check if it is available. | ||
| /// For example: | ||
| // try { | ||
| // await remoteConfig.fetchAndActivate(); | ||
| // final isServerAvailable = remoteConfig.getBool('is_server_available'); | ||
| // serverStatus.value = isServerAvailable ? ServerCheckResult.worksNormally : ServerCheckResult.notActive; | ||
| // } on Exception catch (_) { | ||
| // serverStatus.value = ServerCheckResult.errorOccurred; | ||
| // } | ||
| } |
There was a problem hiding this comment.
It seems that if the method is not implemented, you should add throw NotImplementedException() to the template method body.
| } | ||
|
|
||
| /// Placeholder widget that shows when server is not available. | ||
| /// Replace it with your own widget. |
There was a problem hiding this comment.
Sounds like a good place for // TODO(init-project)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
fix,close,resolveetc. if necessary)New Features