Move to a Docker / Ubuntu 18 build for Linux releases (#1056)

Also add a docker stage in the PR stage
surge-synthesizer · Jul 30, 2024 · 03a75c5 · 03a75c5
1 parent cdd98c4
commit 03a75c5
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 3 deletions.
diff --git a/.github/workflows/build-pr.yml b/.github/workflows/build-pr.yml
@@ -71,3 +71,21 @@ jobs:
           cmake --build build --config Debug --target scxt-test --parallel 4
           ./build/tests/scxt-test
 
+
+  build_plugin_lindoc:
+    name: PR - U18 Docker
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          submodules: recursive
+
+      - name: Build in Docker
+        uses: surge-synthesizer/sst-githubactions/cmake-in-docker@main
+        with:
+          username: ${{ github.actor }}
+          token: ${{ secrets.GITHUB_TOKEN }}
+          cmakeArgs: -DCMAKE_BUILD_TYPE=Debug -GNinja
+          target: scxt_plugin_Standalone
+
diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml
@@ -21,7 +21,6 @@ jobs:
             cmakeArgs: -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang
           - os: macos-latest
             cmakeArgs: -D"CMAKE_OSX_ARCHITECTURES=arm64;x86_64"
-          - os: ubuntu-latest
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -63,11 +62,39 @@ jobs:
           path: build/installer
           name: build-${{ matrix.os }}
 
+  build_plugin_docker:
+    name: Docker Build Ubuntu18
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          submodules: recursive
+
+      - name: Build in Docker
+        uses: surge-synthesizer/sst-githubactions/cmake-in-docker@main
+        with:
+          username: ${{ github.actor }}
+          token: ${{ secrets.GITHUB_TOKEN }}
+          cmakeArgs: -DCMAKE_BUILD_TYPE=Release -GNinja
+          target: shortcircuit-installer
+
+
+      - name: Show Installer Directory
+        run: |
+          ls -l ./build/installer
+
+      - name: Upload artifact
+        uses: actions/upload-artifact@v4
+        with:
+          path: build/installer
+          name: build-docker
+
   publish-scxt-nightly:
     name: Publish scxt Nightly
     if: ${{ github.ref == 'refs/heads/main' && github.repository_owner == 'surge-synthesizer' }}
     runs-on: ubuntu-latest
-    needs: [ build_plugin ]
+    needs: [ build_plugin, build_plugin_docker ]
     steps:
       - name: Upload to Nightly
         uses: surge-synthesizer/sst-githubactions/upload-to-release@main
@@ -91,7 +118,7 @@ jobs:
     name: Publish scxt Release
     if: startsWith(github.ref, 'refs/tags/v') && github.repository_owner == 'surge-synthesizer'
     runs-on: ubuntu-latest
-    needs: [ build_plugin ]
+    needs: [ build_plugin, build_plugin_docker ]
     steps:
       - name: Upload to Release
         uses: surge-synthesizer/sst-githubactions/upload-to-release@main