Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor cleanups mostly in the log #1149

Merged
merged 1 commit into from
Aug 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src-ui/components/multi/OutputPane.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ template <typename OTTraits> struct ProcTab : juce::Component, HasEditor
levelK[i]->setBounds(5 + i * (kw + 5), 40, kw, kw);
levelK[i]->setEnabled(w->processorView.type != dsp::processor::proct_none);
setupWidgetForValueTooltip(levelK[i].get(), levelA[i].get());
SCLOG_ONCE("Fix up accessibility for this knob");
addAndMakeVisible(*levelK[i]);
}
}
Expand Down
6 changes: 5 additions & 1 deletion src-ui/components/multi/PartSidebarCard.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,18 @@ void PartSidebarCard::paint(juce::Graphics &g)
}
else
{
g.setColour(editor->themeColor(theme::ColorMap::generic_content_medium));
g.setColour(editor->themeColor(theme::ColorMap::accent_1a).withAlpha(0.3f));
}
if (selfAccent)
{
auto rb = getLocalBounds().reduced(1);

g.drawRoundedRectangle(rb.toFloat(), 2, 1);
}
if (editor->getSelectedPart() != part)
{
g.setColour(editor->themeColor(theme::ColorMap::generic_content_medium));
}
auto r = juce::Rectangle<int>(5, row0 + rowMargin, 18, rowHeight - 2 * rowMargin);
g.setFont(editor->themeApplier.interMediumFor(12));
g.drawText(std::to_string(part + 1), r, juce::Justification::centred);
Expand Down
2 changes: 1 addition & 1 deletion src-ui/connectors/PayloadDataAttachment.h
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ std::unique_ptr<T> makeConnectedToDummy(uint32_t index, const std::string &lab,
t = t << 8;
}

SCLOG("Incomplete UI bound to dummy source '" << s << "'");
// SCLOG("Incomplete UI bound to dummy source '" << s << "'");
}

res->setSource(thisWillLeak);
Expand Down
1 change: 0 additions & 1 deletion src-ui/theme/ThemeApplier.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ ThemeApplier::ThemeApplier()
static bool detailInitialized{false};
if (!detailInitialized)
{
SCLOG("Initializing All Theme Stylesheets");
detail::multi::init();
detail::multi::zone::init();
detail::multi::group::init();
Expand Down
4 changes: 3 additions & 1 deletion src/engine/engine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ namespace scxt::engine

Engine::Engine()
{
SCLOG("Shortcircuit XT : Constructing Engine - Version " << scxt::build::FullVersionStr);
SCLOG("Shortcircuit XT : Constructing Engine");
SCLOG(" Version = " << scxt::build::FullVersionStr);
SCLOG(" Stream V = " << humanReadableVersion(scxt::currentStreamingVersion));

id.id = rng.unifU32() % 1024;

Expand Down
16 changes: 1 addition & 15 deletions src/engine/engine.h
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ struct Engine : MoveableOnly<Engine>, SampleRateSupport
uint64_t pVer{0};
explicit UnstreamGuard(uint64_t sv)
{
SCLOG("Unstreaming engine with streaming version = " << scxt::humanReadableVersion(sv));
SCLOG("Unstreaming engine::Engine. Version : " << scxt::humanReadableVersion(sv));
pIs = engine::Engine::isFullEngineUnstream;
pVer = engine::Engine::fullEngineUnstreamStreamingVersion;
engine::Engine::isFullEngineUnstream = true;
Expand All @@ -366,20 +366,6 @@ struct Engine : MoveableOnly<Engine>, SampleRateSupport
StreamReason pIs{IN_PROCESS};
explicit StreamGuard(StreamReason sr)
{
switch (sr)
{
case IN_PROCESS:
SCLOG("Engine Stream Guard - In Process");
break;

case FOR_DAW:
SCLOG("Engine Stream Guard - For DAW");
break;

case FOR_MULTI:
SCLOG("Engine Stream Guard - For Multi");
break;
}
pIs = engine::Engine::streamReason;
engine::Engine::streamReason = sr;
}
Expand Down
2 changes: 1 addition & 1 deletion src/modulation/group_matrix.h
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ struct GroupMatrixEndpoints
LFOTarget(engine::Engine *e, uint32_t p) : shared::LFOTargetEndpointData<TG, 'glfo'>(p)
{
if (e)
SCLOG_UNIMPL("Engine Attach Group LFO");
SCLOG_UNIMPL_ONCE("Engine Attach Group LFO");
}
void bind(GroupMatrix &m, engine::Group &g);
};
Expand Down
2 changes: 1 addition & 1 deletion src/sample/sample_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ std::optional<SampleID> SampleManager::loadSampleByPathToID(const fs::path &p, c
}
}

SCLOG("Loading sample " << p.u8string() << " into " << id.to_string());
SCLOG("Loading [" << p.u8string() << "] @ [" << id.to_string() << "]");

auto sp = std::make_shared<Sample>(id);

Expand Down
2 changes: 2 additions & 0 deletions src/utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,8 @@ std::string logTimestamp();

#define SCLOG_WFUNC(...) SCLOG(__func__ << " " << __VA_ARGS__)
#define SCLOG_UNIMPL(...) SCLOG("\033[1;33mUnimpl [" << __func__ << "]\033[0m " << __VA_ARGS__);
#define SCLOG_UNIMPL_ONCE(...) \
SCLOG_ONCE("\033[1;33mUnimpl [" << __func__ << "]\033[0m " << __VA_ARGS__);
#define SCD(x) #x << "=" << (x) << " "

#define DECLARE_ENUM_STRING(E) \
Expand Down
Loading