Fix UTF encoding issues for wav sample and MSVC build #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reliably maintain unicode encoding on all strings for dragging a wav file from the browser into the engine and storing it in a multi. This fixes that simple case but we need a top to bottom review of all the other stream-a-path gestures in the codebase (although I think this is the majority of them) Also MSVC has a bug with double-this-binding in lambdas which this commit fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reliably maintain unicode encoding on all strings for dragging a wav file from the browser into the engine and storing it in a multi. This fixes that simple case but we need a top to bottom review of all the other stream-a-path gestures in the codebase (although I think this is the majority of them)
Also MSVC has a bug with double-this-binding in lambdas which this commit fixes