Int and Power on Runnign Voices and Groups for procs #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Int values snap every block from zone (voice) and group (group) meaning running voices experience and reset int params 2. The power/bypass button works on voices and groups for processors. this does change the voice allocation pattern slightly in that we init a processor on voice on whether active or not since we don't want to do mid-init power on for a bypassed processor which becomes unbypassed, but we don't run it, just init it 3. Add the gnarly per-block logic to deal with processor type changes in running voices, not just running groups. Closes surge-synthesizer#957
baconpaul
force-pushed
the
int-and-active-957
branch
from
92dd1b0
to
b486f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meaning running voices experience and reset int params
this does change the voice allocation pattern slightly in that
we init a processor on voice on whether active or not since we
don't want to do mid-init power on for a bypassed processor which
becomes unbypassed, but we don't run it, just init it
changes in running voices, not just running groups.
Closes #957