Fix a problem with optimization 5bcfdb5400 #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 5bcfdb5 changed the way groups traverse zones to only include active zones, but a zone deactivates during processing, so legato patterns with zones exiting could cause pops when the zone re-ordered in the loop Fix this by defering the re-pack the weak pointer operation until after the zone traversal Closes surge-synthesizer#1329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 5bcfdb5 changed the way groups traverse zones to only include active zones, but a zone deactivates during processing, so legato patterns with zones exiting could cause pops when the zone re-ordered in the loop
Fix this by defering the re-pack the weak pointer operation until after the zone traversal
Closes #1329