Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a problem with optimization 5bcfdb5400 #1330

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Fix a problem with optimization 5bcfdb5400 #1330

merged 2 commits into from
Sep 15, 2024

Commits on Sep 15, 2024

  1. Fix a problem with optimization 5bcfdb5 

    Commit  5bcfdb5 changed the way groups traverse zones to only
include active zones, but a zone deactivates during processing,
so legato patterns with zones exiting could cause pops when the
zone re-ordered in the loop

Fix this by defering the re-pack the weak pointer operation until
after the zone traversal

Closes surge-synthesizer#1329
    @baconpaul
    baconpaul committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    fbd2ff0 View commit details
    Browse the repository at this point in the history

  2. f

    @baconpaul
    baconpaul committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    2a56914 View commit details
    Browse the repository at this point in the history