Fix a unison RR voice manager problem and reduce zone search #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The unison round robin interacted improperly with the voice manager and so created orphaned voices. Fix this bu changing the voice manager to have a transaction boundary around voice creation with a begin-for-count, make-up-to-count and end, which allows internal state to be constructed more evenly in the responder 2. This means the begin count counts the unison voices so the initiate just sees each unison as a different entry 3. This also means we can cache the findZone result from voice count rather than redo it, while still using fixed sized memory vehicles Closes surge-synthesizer#1192 Closes surge-synthesizer#1241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1192
Closes #1241