Starting on depth slider throw scaling #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit injects a rescaling data adapter between the depth slider and the underlying depth which basically uses a cube / cuberoot on the depth slider. This is part of the plan for surge-synthesizer#767 but not all of it With this a 1 semitone pitch adjustment is about 25% of the total throw so it is already a vast improvement, so merge it for now to make the synth generaly way less annoying to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit injects a rescaling data adapter between the depth slider and the underlying depth which basically uses a cube / cuberoot on the depth slider. This is part of the plan for #767 but not all of it
With this a 1 semitone pitch adjustment is about 25% of the total throw so it is already a vast improvement, so merge it for now to make the synth generaly way less annoying to use.