Restructure SF2 to not over-load #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SF2 indexes samples by the preset/instrument/region but that resolves to a sample index. Since I was using P/I/R as SampleID that meant identical samples had different IDs and thus loaded multiple times. Defacto this made a 3MB SF2 with lots of instruments load as 90MB and stuff. Ugh. So fix this in two ways 1. Make loadeFromSF2 (p,i,r) remap the sample to index if needed 2. Change the sample->load to be index based and voila
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SF2 indexes samples by the preset/instrument/region but that resolves to a sample index. Since I was using P/I/R as SampleID that meant identical samples had different IDs and thus loaded multiple times. Defacto this made a 3MB SF2 with lots of instruments load as 90MB and stuff. Ugh.
So fix this in two ways
and voila