Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get-secrets #1507

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: add get-secrets #1507

wants to merge 6 commits into from

Conversation

suzuki-shunsuke
Copy link
Owner

No description provided.

@rochana-atapattu
Copy link
Contributor

@suzuki-shunsuke I'm looking to add an interface to allow other secret managers to easily integrate with this, like GCP Secret Manager. I'm unable to build this and run it in my local env to get a baseline before I start dev. I'm getting following error.

~/repo/rochana-atapattu/tfaction/main/get-secrets  v20.10.0
▷ tree -I node_modules                                                                                                                                   feat/add-get-secrets
.
├── action.yaml
├── dist
│   ├── LICENSE
│   └── index.js
├── package-lock.json
├── package.json
├── src
│   ├── index.ts
│   └── run.ts
├── test
│   └── tfaction.yaml
├── tfaction-root.yaml
└── tsconfig.json

4 directories, 10 files

~/repo/rochana-atapattu/tfaction/main/get-secrets  v20.10.0
▷ npm run build                                                                                                                                          feat/add-get-secrets

> build
> ncc build src/index.ts --license LICENSE

ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
ncc: Using typescript@5.3.3 (local user-provided)
 635kB  dist/LICENSE
1812kB  dist/index.js
2447kB  [2289ms] - ncc 0.38.1

~/repo/rochana-atapattu/tfaction/main/get-secrets  v20.10.0
▷ TFACTION_TARGET=test/tfaction.yaml TFACTION_JOB_TYPE=terraform node dist/index.js                                                                      feat/add-get-secrets
node:internal/modules/cjs/loader:1147
  throw err;
  ^

Error: Cannot find module 'zod'
Require stack:
- /Users/rochana/repo/rochana-atapattu/tfaction/main/get-secrets/dist/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
    at Module._load (node:internal/modules/cjs/loader:985:27)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at 53561 (/Users/rochana/repo/rochana-atapattu/tfaction/main/get-secrets/dist/index.js:48702:33)
    at __nccwpck_require__ (/Users/rochana/repo/rochana-atapattu/tfaction/main/get-secrets/dist/index.js:50620:43)
    at 48022 (/Users/rochana/repo/rochana-atapattu/tfaction/main/get-secrets/dist/index.js:48263:15)
    at __nccwpck_require__ (/Users/rochana/repo/rochana-atapattu/tfaction/main/get-secrets/dist/index.js:50620:43)
    at 7764 (/Users/rochana/repo/rochana-atapattu/tfaction/main/get-secrets/dist/index.js:48600:26)
    at __nccwpck_require__ (/Users/rochana/repo/rochana-atapattu/tfaction/main/get-secrets/dist/index.js:50620:43) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/rochana/repo/rochana-atapattu/tfaction/main/get-secrets/dist/index.js'
  ]
}

P.S: I have very little experience with TypeScript and Nodejs latest ecosystem.

@suzuki-shunsuke
Copy link
Owner Author

This pull request is still work in progress.
I haven't been able to work on this for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants