Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to use given variables for linux .rpm agent version determination #33

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

mwester117
Copy link
Collaborator

Solves #32.
Just code refactoring and making code more efficient.

@mwester117 mwester117 requested a review from nwerker March 29, 2024 11:02
@mwester117 mwester117 marked this pull request as ready for review March 29, 2024 11:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.14%. Comparing base (5af23e9) to head (a1e957d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   20.14%   20.14%           
=======================================
  Files           9        9           
  Lines        1092     1092           
  Branches      212      212           
=======================================
  Hits          220      220           
  Misses        872      872           
Flag Coverage Δ
sanity 20.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwerker nwerker merged commit 5f911e5 into main Apr 8, 2024
22 checks passed
@mwester117 mwester117 deleted the feature_refactor_versioncheck branch May 27, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Feature request: Refactor code for easier version check of rpm packages
3 participants