Fix warnings on Emacs >= 29.1 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The code does not seem to need cl, which in later Emacs should be cl-lib. Eliminating its require statement get rid of one problem. - `ibuffer-remove-duplicates' is obsolete as of Emacs 29.1. Now check Emacs version and use `seq-uniq' instead. Also prevent byte compiler warning for code supporting older version of Emacs. - `ibuffer-awhen' macro is obsolete as of Emacs 29.1. Replace the code by its expansion. The expansion is small anyway. This allows being compatible with new version of Emacs while keeping compatibility with older versions of Emacs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ibuffer-remove-duplicatesis obsolete as of Emacs 29.1. Now check Emacs version and use `seq-uniq' instead. Also prevent byte compiler warning for code supporting older version of Emacs.ibuffer-awhenmacro is obsolete as of Emacs 29.1. Replace the code by its expansion. The expansion is small anyway. This allows being compatible with new version of Emacs while keeping compatibility with older versions of Emacs.