Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operationsSorter and tagsSorter support to docker image #8343

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

dmlyons
Copy link

@dmlyons dmlyons commented Jan 11, 2023

Added support for the sorting configurations

Description

Added the ability to pass environment variables for operations sorting and tag sorting.

Motivation and Context

Fixes #6154

How Has This Been Tested?

Ran locally in docker and played with the sorting options and saw that they had the intended effect.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • [ X ] Bug fixes (non-breaking change which fixes an issue)
  • [ X ] Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • [ X ] are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • [ X ] My changes require a change to the project documentation.
  • [ X ] If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.

  • My changes can and should be tested by unit and/or integration tests.

  • If yes to above: I have added tests to cover my changes.

  • If yes to above: I have taken care to cover edge cases in my tests.

  • [ x ] All existing tests passed.

@frontvu
Copy link

frontvu commented Feb 21, 2023

Would love to see this get merged. Anything I can do to help?

@dmlyons
Copy link
Author

dmlyons commented Mar 21, 2023

This is a really simple change, is there anything else that I can do?

@dmlyons
Copy link
Author

dmlyons commented Jun 8, 2023

Hello? Is this thing on?

@dmlyons
Copy link
Author

dmlyons commented Jul 15, 2023

What can I do to move this along?

@os-cas
Copy link

os-cas commented Aug 14, 2023

Would love to see this merged as well!

@arthurgurov
Copy link

Any chance to merge this? It's really a small thing but very convenient from the consumer standpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tagSorter and operationSorter options on Docker
4 participants