Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixes #264

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Typo fixes #264

merged 10 commits into from
Jan 8, 2025

Conversation

dc2917
Copy link
Contributor

@dc2917 dc2917 commented Jan 6, 2025

Closes #263

This PR fixes some typos throughout the course. Some of these were minor (missing punctuation) but some were more considerable, for instance:

  • Exercises ask learners to perform operations on the string 'aluminum', while the solutions use 'aluminium'.
  • A calculation to sum the positive values in an array stated the incorrect result (despite the function being correct)
  • There was a reference to a variable 'filename', which should have been 'file_name'
  • There was a reference to a variable 'output_range', which should have been 'overlap' - this caused assertions to fail
  • References to line numbers have been updated
  • end statements have been added to functions where missing

Copy link

github-actions bot commented Jan 6, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/matlab-novice-inflammation/compare/md-outputs..md-outputs-PR-264

The following changes were observed in the rendered markdown documents:

 02-arrays.md    |  2 +-
 03-plotting.md  |  2 +-
 04-scripts.md   |  2 +-
 05-loops.md     |  4 ++--
 06-cond.md      |  4 ++--
 08-defensive.md | 12 ++++++++----
 md5sum.txt      | 12 ++++++------
 7 files changed, 21 insertions(+), 17 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-01-06 16:55:04 +0000

github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
@dc2917 dc2917 merged commit a50187d into swcarpentry:main Jan 8, 2025
3 checks passed
@dc2917 dc2917 deleted the typo_fixes branch January 8, 2025 10:43
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
Auto-generated via `{sandpaper}`
Source  : a50187d
Branch  : main
Author  : Dan Cummins <45606273+dc2917@users.noreply.github.com>
Time    : 2025-01-08 10:43:50 +0000
Message : Merge pull request #264 from dc2917/typo_fixes

Typo fixes
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
Auto-generated via `{sandpaper}`
Source  : 9ea6c63
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-01-08 10:44:42 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : a50187d
Branch  : main
Author  : Dan Cummins <45606273+dc2917@users.noreply.github.com>
Time    : 2025-01-08 10:43:50 +0000
Message : Merge pull request #264 from dc2917/typo_fixes

Typo fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typos throughout course
1 participant