Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linebreak in looping example #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ndporter
Copy link
Contributor

Add a newline in the print for the looping over files minimum example to improve readability of output.

Added a newline in the print for the looping over files minimum example to improve readability of output.
@github-actions
Copy link

github-actions bot commented May 19, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-647

The following changes were observed in the rendered markdown documents:

 14-looping-data-sets.md | 8 +++++---
 md5sum.txt              | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-05-19 19:25:02 +0000

github-actions bot pushed a commit that referenced this pull request May 19, 2023
@ndporter
Copy link
Contributor Author

I noted later: I think there are other exercises this update would apply to as well. I won't have time to check in the near future though. Probably either someone should scan through the code/output in this episode or create an issue to follow up.

@martinosorb
Copy link
Contributor

Hi @ndporter, thank you for the PR. I note however that this requires explaining what \n means. Do you remember if there's another place before this point where it is used in the lesson materials?

Alternatively, what do you think of doing two prints? As in

print(filename)
print(data.min())

@ndporter
Copy link
Contributor Author

ndporter commented May 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants