-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add linebreak in looping example #647
base: main
Are you sure you want to change the base?
Conversation
Added a newline in the print for the looping over files minimum example to improve readability of output.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-647 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-05-19 19:25:02 +0000 |
I noted later: I think there are other exercises this update would apply to as well. I won't have time to check in the near future though. Probably either someone should scan through the code/output in this episode or create an issue to follow up. |
Hi @ndporter, thank you for the PR. I note however that this requires explaining what Alternatively, what do you think of doing two prints? As in
|
The `\n` construction is used as early as the[pandas data frames](
http://swcarpentry.github.io/python-novice-gapminder/aio.html#use-comparisons-to-select-data-based-on-value)
lesson (link from aio because doing search on my phone). I don't know that
they're actually introduced in the lesson anywhere, though.
So you're right that it would be good to explain them somewhere, and if not
in a main lesson then at least in instructor notes. But I was actually
following the model of earlier lessons in the PR.
…On Mon, May 22, 2023, 4:40 AM Martino Sorbaro ***@***.***> wrote:
Hi @ndporter <https://github.com/ndporter>, thank you for the PR. I note
however that this requires explaining what \n means. Do you remember if
there's another place before this point where it is used in the lesson
materials?
Alternatively, what do you think of doing two prints? As in
print(filename)
print(data.min())
—
Reply to this email directly, view it on GitHub
<#647 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOKE445VBKDVHPDP3GF663XHMQ7ZANCNFSM6AAAAAAYIE4X3Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Add a newline in the print for the looping over files minimum example to improve readability of output.