Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data in place of feline-data_v2.csv, closes #717 #908

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

caseyyoungflesh
Copy link
Contributor

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

Closes #717. The lesson 04-data-structures-part1 has been missing feline-data_v2.csv for some time without being added. The lesson says to read in this .csv and then use it for an exercise. Changed so that a data.frame is created rather than reading in the non-existent .csv.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

Copy link

github-actions bot commented Jan 6, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-908

The following changes were observed in the rendered markdown documents:

 04-data-structures-part1.md | 90 +++++++++++++++++++--------------------------
 data/feline-data.csv        |  2 +-
 md5sum.txt                  |  2 +-
 3 files changed, 40 insertions(+), 54 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-01-07 15:37:00 +0000

github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
@matthieu-bruneaux
Copy link
Contributor

Thank you for looking into this issue @caseyyoungflesh. I think your proposed changes will make the life of students and instructors following this episode easier.

I took the liberty of making a few extra edits to keep the rest of the episode text consistent with the proposed changes.

LGTM for merging (cc @skanwal or @naupaka for confirmation).

@naupaka
Copy link
Member

naupaka commented Jan 7, 2025

Thanks, @caseyyoungflesh for the changes, this has needed to be addressed for a while. And thanks @matthieu-bruneaux for the review and revisions. It looks like there are some issues with the automated checks that should be resolved prior to merging. I am not quite sure what is causing them, perhaps some issue with the automated build system?

@skanwal
Copy link
Contributor

skanwal commented Jan 7, 2025

One of the build files is returning:

##[error]Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

trying to address this with #909

github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
@naupaka
Copy link
Member

naupaka commented Jan 7, 2025

Checks passed, merging. Thanks all!

@naupaka naupaka merged commit cd7dbe7 into swcarpentry:main Jan 7, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
Auto-generated via `{sandpaper}`
Source  : cd7dbe7
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2025-01-07 18:05:01 +0000
Message : Merge pull request #908 from caseyyoungflesh/04-fix_feline-data_v2.csv

Add data in place of `feline-data_v2.csv`, closes #717
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
Auto-generated via `{sandpaper}`
Source  : baf8fe2
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-01-07 18:06:14 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : cd7dbe7
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2025-01-07 18:05:01 +0000
Message : Merge pull request #908 from caseyyoungflesh/04-fix_feline-data_v2.csv

Add data in place of `feline-data_v2.csv`, closes #717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The origin of feline-data_v2.csv not specified
4 participants