From 57ddbc8153b170d1d81b791ce8ea44b54577c413 Mon Sep 17 00:00:00 2001 From: John Yang Date: Tue, 10 Dec 2024 00:53:57 +0000 Subject: [PATCH] Remove logic to rebuild based on creation date --- swebench/harness/docker_build.py | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/swebench/harness/docker_build.py b/swebench/harness/docker_build.py index 5bd3bca7..5ff6779b 100644 --- a/swebench/harness/docker_build.py +++ b/swebench/harness/docker_build.py @@ -240,14 +240,6 @@ def get_env_configs_to_build( try: env_image = client.images.get(test_spec.env_image_key) image_exists = True - - if env_image.attrs["Created"] < base_image.attrs["Created"]: - # Remove the environment image if it was built after the base_image - for dep in find_dependent_images(client, test_spec.env_image_key): - # Remove instance images that depend on this environment image - remove_image(client, dep, "quiet") - remove_image(client, test_spec.env_image_key, "quiet") - image_exists = False except docker.errors.ImageNotFound: pass if not image_exists: @@ -454,13 +446,8 @@ def build_instance_image( # Check if the instance image already exists image_exists = False try: - instance_image = client.images.get(image_name) - if instance_image.attrs["Created"] < env_image.attrs["Created"]: - # the environment image is newer than the instance image, meaning the instance image may be outdated - remove_image(client, image_name, "quiet") - image_exists = False - else: - image_exists = True + client.images.get(image_name) + image_exists = True except docker.errors.ImageNotFound: pass