Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted config items in local or shared jsons are not removed from generated files #160

Open
mgzenitech opened this issue Jan 9, 2024 · 2 comments

Comments

@mgzenitech
Copy link

mgzenitech commented Jan 9, 2024

Example:
settings.shared.json

{
    "editor.detectIndentation": false
}

generates settings.json

{
    "editor.detectIndentation": false
}

Now if afterwards I'd comment out it in settings.shared.json:

{
    //"editor.detectIndentation": false
}

I'm left with the same settings.json:

{
    "editor.detectIndentation": false
}

Expected output would be for settings.json:

{
}
@calebcartwright
Copy link
Member

Thanks for sharing. The issue title refers to deleting items, but the snippets and description refer to commenting things out. Are you able to reproduce the described behavior when deleting the lines? Or is it only when you comment something out?

@mgzenitech
Copy link
Author

Thanks for sharing. The issue title refers to deleting items, but the snippets and description refer to commenting things out. Are you able to reproduce the described behavior when deleting the lines? Or is it only when you comment something out?

Same thing in both situations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants