New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review required CI checks for PRs #64

Open

calebcartwright opened this issue Feb 12, 2020 · 0 comments

Member

calebcartwright commented Feb 12, 2020

We've currently got an array of PR checks that are required/gates for merging to master, including one for running Sonar scans.

However, our current config also disallows the execution of the Sonar scan on checks for PRs coming from forks (config on the Azure Pipelines side).

The end result is that PRs coming from forks will always have a failed check, so this needs to be changed. Few options I see:

Update the config to allow running the Sonar scan, even coming from a fork
Disable the Sonar scan job for forks (this may require updating the branch protection policies for master too)
Disable the Sonar scan as a PR check altogether and only run it in the CI job post-merge (I'm against this one philosophically FWIW)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment