Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove additional semicolon #496

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Remove additional semicolon #496

merged 2 commits into from
Nov 20, 2024

Conversation

armallen
Copy link
Contributor

@armallen armallen commented Oct 30, 2024 •
edited
Loading

DEFINE_GET_PARAMS, DEFINE_SET_PARAM and DECLARE_PARAMS declare ; by themselves, calling ALBATROSS_DECLARE_PARAMS leads to ;; being declared, which is not allowed by compilers with strict warnings.

Tested in https://github.com/swift-nav/orion-engine/pull/8882

@armallen armallen requested review from akleeman and peddie November 19, 2024 11:57
peddie
peddie approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@peddie peddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: semi colon :)

@armallen armallen changed the title Remove additional semicolumn Remove additional semicolon Nov 20, 2024
@armallen armallen merged commit 13a56a1 into master Nov 20, 2024
9 checks passed
@armallen armallen deleted the armallen/additional-semicolumn branch November 20, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peddie peddie peddie approved these changes

@akleeman akleeman Awaiting requested review from akleeman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armallen @peddie