Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: repair the build on Windows #20

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Commits on Mar 29, 2024

  1. build: repair the build on Windows

    Replicate the behaviour from upstream ICU:
      ```
      #if defined(U_TIMEZONE) || defined(U_HAVE_TIMEZONE)
          /* Use the predefined value. */
      #elif U_PLATFORM == U_PF_ANDROID
      #   define U_TIMEZONE timezone
      #elif defined(__UCLIBC__)
          // uClibc does not have __timezone or _timezone.
      #elif defined(_NEWLIB_VERSION)
      #   define U_TIMEZONE _timezone
      #elif defined(__GLIBC__)
          // glibc
      #   define U_TIMEZONE __timezone
      #elif U_PLATFORM_IS_LINUX_BASED
          // not defined
      #elif U_PLATFORM_USES_ONLY_WIN32_API
      #   define U_TIMEZONE _timezone
      #elif U_PLATFORM == U_PF_BSD && !defined(__NetBSD__)
         /* not defined */
      #elif U_PLATFORM == U_PF_OS400
         /* not defined */
      #elif U_PLATFORM == U_PF_IPHONE
         /* not defined */
      #else
      #   define U_TIMEZONE timezone
      #endif
      ```
    
    With this change, ICU at least builds, but it is unclear if it functions
    properly on Windows.
    compnerd committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b643747 View commit details
    Browse the repository at this point in the history