Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
JSObject.construct(from:)
failed withJSValue
s where its case is function, symbol, or bigInt.For example,
JSFunction.construct
succeeds withcase function
andJSObject.construct
doesn't, but it should succeed becauseJSFunction
is aJSObject
.symbol and bigint are primitive values in JavaScript side, and because of:
It's unclear if
JSObject.construct(symbol)
should succeed or nor, but I think it should becauseJSSymbol
is aJSObject
.Note for
function
case:従来の実装では、
JSValue
の case が function, symbol, bigInt であるような JSValue を、JSObject.construct(from:)
に渡した場合にデコードに失敗していました。例えば
JSFunction.construct
に case function を渡す場合は成功しますが、値がfunction であるとわからない状況においても、
JSFunction
isJSObject
である以上、JSObject
としてのデコードが成功する必要があります。symbol と bigInt については JavaScript側においてはプリミティブであり、
なので、
JSObject
としてデコードできるのが正しいのかよくわからないですが、少なくとも
JSSymbol
isJSObject
となっている以上は、そうなるべきだと思います。
ちなみに function については
です。