Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert that JSObject is being accessed only from the owner thread #273

Merged
merged 10 commits into from
Nov 28, 2024

Conversation

kateinoigakukun
Copy link
Member

This is not the ideal solution but it's much better than silently corrupting the heap space. Partially resolve #271

Copy link

github-actions bot commented Nov 28, 2024

Time Change: +94ms (0%)

Total Time: 9,553ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 14ms -1ms
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import 18ms -0ms
Serialization/JavaScript function call from Swift 108ms +1ms
Serialization/Swift Int to JavaScript with assignment 321ms -3ms (0%)
Serialization/Swift Int to JavaScript with call 1,020ms +24ms (2%)
Serialization/JavaScript Number to Swift Int 291ms +1ms
Serialization/Swift String to JavaScript with assignment 385ms +3ms (0%)
Serialization/Swift String to JavaScript with call 1,065ms +4ms (0%)
Serialization/JavaScript String to Swift String 3,650ms +52ms (1%)
Object heap/Increment and decrement RC 2,670ms +16ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 2ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 2ms
Serialization/Call with JavaScript string directly 2ms

@kateinoigakukun kateinoigakukun merged commit 1546b94 into main Nov 28, 2024
18 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/worker-deinit branch November 28, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSObject on worker A can be deallocated on worker B
1 participant