[SDCISA-13736, SDCISA-10974] Adjust error reporting #546

hiddenalpha · 2024-01-05T16:38:19Z

No description provided.

- Log concealed errors. - Uncover some submarines. - Cache some refs in locals. - Replace nonsense iteration construct. - Add some static/final modifiers.

codecov · 2024-01-05T17:49:17Z

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (31e8e01) 47.61% compared to head (1418a77) 47.59%.

Files	Patch %	Lines
...ateleen/core/lock/lua/ReleaseLockRedisCommand.java	38.09%	11 Missing and 2 partials ⚠️
...rg/swisspush/gateleen/core/lua/LuaScriptState.java	56.00%	7 Missing and 4 partials ⚠️
...re/configuration/ConfigurationResourceManager.java	66.66%	3 Missing and 3 partials ⚠️
...sspush/gateleen/core/lock/impl/RedisBasedLock.java	61.53%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #546      +/-   ##
=============================================
- Coverage      47.61%   47.59%   -0.03%     
- Complexity      1786     1789       +3     
=============================================
  Files            225      225              
  Lines          11736    11767      +31     
  Branches        1228     1233       +5     
=============================================
+ Hits            5588     5600      +12     
- Misses          5660     5673      +13     
- Partials         488      494       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gateleen-core/src/main/java/org/swisspush/gateleen/core/util/LockUtil.java

gateleen-core/src/main/java/org/swisspush/gateleen/core/lua/LuaScriptState.java

dominik-cnx · 2024-01-08T02:50:10Z

gateleen-core/src/main/java/org/swisspush/gateleen/core/http/LocalHttpClientRequest.java

@@ -776,6 +797,8 @@ public boolean writeQueueFull() {

    @Override
    public HttpClientRequest drainHandler(Handler<Void> handler) {
+        log.warn("Happy debugging, as this impl will just ignore your drainHandler anyway",


We expect or actually know that it we would log this newly added warning only in some rare edge cases, right?

I have no idea when it is called. And that's exactly the point why I add this log. As soon someone calls this method (if at all), it is a guarantee for a hung-up request (eg timeout) with totally useless error messages where the stack points somewhere into vertx. The issue is, it is hard to predict when (if at all) this method is called due to indirections and abstractions.

gateleen-core/src/main/java/org/swisspush/gateleen/core/http/BufferBridge.java

This applies some (unrelated) changes requested in swisspost#546 .

…s-20240105-1528 Conflicts: gateleen-core/src/main/java/org/swisspush/gateleen/core/http/BufferBridge.java

…lyFindings-20240105-1528 Conflicts: gateleen-core/src/main/java/org/swisspush/gateleen/core/lua/LuaScriptState.java

[SDCISA-13736, SDCISA-10974] Enhance error reporting

c181099

- Log concealed errors. - Uncover some submarines. - Cache some refs in locals. - Replace nonsense iteration construct. - Add some static/final modifiers.

hiddenalpha force-pushed the SDCISA-13736-ApplyFindings-20240105-1528 branch from 539191b to c181099 Compare January 5, 2024 17:45

hiddenalpha marked this pull request as ready for review January 5, 2024 19:20

hiddenalpha requested review from mcweba, Kusig, ljucam, gateleen, Swisspusher, linovifian and a team January 5, 2024 19:21

Kusig approved these changes Jan 7, 2024

View reviewed changes