Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDCISA-13736, SDCISA-10974] Apply off-topic changes #547

Conversation

hiddenalpha
Copy link
Member

This applies some (unrelated) changes requested in #546 .

This applies some (unrelated) changes requested in
swisspost#546
.
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (51b5486) 47.58% compared to head (534cb50) 47.58%.

Files Patch % Lines
...rg/swisspush/gateleen/core/lua/LuaScriptState.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #547   +/-   ##
==========================================
  Coverage      47.58%   47.58%           
  Complexity      1786     1786           
==========================================
  Files            225      225           
  Lines          11736    11736           
  Branches        1228     1228           
==========================================
  Hits            5585     5585           
  Misses          5663     5663           
  Partials         488      488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddenalpha hiddenalpha merged commit 31e8e01 into swisspost:develop Jan 10, 2024
3 checks passed
@hiddenalpha hiddenalpha deleted the SDCISA-13736-ApplyFindings-20240108-0954 branch January 10, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants