[SDCISA-13736, SDCISA-13746] Fix YAGNI error handling in Scheduler.java #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #556 +/- ##
=============================================
+ Coverage 47.44% 47.47% +0.02%
- Complexity 1790 1791 +1
=============================================
Files 225 225
Lines 11815 11820 +5
Branches 1237 1239 +2
=============================================
+ Hits 5606 5611 +5
+ Misses 5715 5714 -1
- Partials 494 495 +1 ☔ View full report in Codecov by Sentry. |
hiddenalpha
requested review from
mcweba,
Kusig,
ljucam,
gateleen,
Swisspusher,
linovifian and
a team
dominik-cnx
reviewed
Jan 31, 2024
| String queueName = "scheduler-" + name; | ||
| JsonObject enqueOp = buildEnqueueOperation(queueName, request.toJsonObject().put(QueueClient.QUEUE_TIMESTAMP, System.currentTimeMillis()).encode()); | ||
| vertx.eventBus().request(redisquesAddress, enqueOp, (Handler<AsyncResult<Message<JsonObject>>>) event -> { | ||
| if( event.failed() ){ |
dominik-cnx
reviewed
Jan 31, 2024
| JsonObject enqueOp = buildEnqueueOperation(queueName, request.toJsonObject().put(QueueClient.QUEUE_TIMESTAMP, System.currentTimeMillis()).encode()); | ||
| vertx.eventBus().request(redisquesAddress, enqueOp, (Handler<AsyncResult<Message<JsonObject>>>) event -> { | ||
| if( event.failed() ){ | ||
| if( log.isWarnEnabled() ) log.warn("Could not enqueue request '{}' '{}'", queueName, request.getUri(), new Exception(event.cause())); |
There was a problem hiding this comment.
Do we need to wrap the cause in an exception?
There was a problem hiding this comment.
Just imagine how the stack would look like if we don't. HINT: Our code here WILL NOT be in that stack.
dominik-cnx
approved these changes
Jan 31, 2024
mcweba
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix YAGNI error handling in Scheduler.java