PR for release #178
Merged
PR for release #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libraries must not include logger implementations. It is the applications choice which logger implementation to use. Not a libraries one. Including logger implementations from within libraries defeats the whole purpose of having a logging facade at all. And makes logger configuration in applications a nightmare, as they need to configure all logger impls pulled in somewhere by some library deep down the dependency tree. Relates to: - swisspost/vertx-redisques#153 - https://jira.post.ch/browse/SDCISA-13746
…ogger-impls-20240321
Bumps [io.vertx:vertx-core](https://github.com/eclipse/vert.x) from 4.5.1 to 4.5.2. - [Commits](eclipse-vertx/vert.x@4.5.1...4.5.2) --- updated-dependencies: - dependency-name: io.vertx:vertx-core dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…rics #176 log redis metrics
…x-core-4.5.2 Bump io.vertx:vertx-core from 4.5.1 to 4.5.2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
============================================
- Coverage 62.54% 62.42% -0.13%
- Complexity 392 417 +25
============================================
Files 32 35 +3
Lines 2582 2685 +103
Branches 298 307 +9
============================================
+ Hits 1615 1676 +61
- Misses 806 845 +39
- Partials 161 164 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.