Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter steer against too noisy logs #186

Merged

Conversation

hiddenalpha
Copy link
Member

@hiddenalpha hiddenalpha commented May 21, 2024

In one downstream project we need more error details (like stacktraces) for bug hunting. But in another downstream project, this causes performance issues due to too much stack traces. This change provides the base to fulfill both projects needs.

@hiddenalpha hiddenalpha requested review from mcweba, Kusig, ljucam, linovifian and a team May 21, 2024 12:48
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request May 21, 2024
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 21, 2024
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 21, 2024
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request May 21, 2024
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 21, 2024
Copy link
Collaborator

@mcweba mcweba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good. Before merging this to develop I would suggest to replace all occurrences of logging new Exception(...) with the new factory method

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 33.55705% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 62.15%. Comparing base (c8e1083) to head (701dce2).
Report is 9 commits behind head on develop.

Current head 701dce2 differs from pull request most recent head 25cdec3

Please upload reports for the commit 25cdec3 to get more accurate results.

Files Patch % Lines
.../org/swisspush/reststorage/redis/RedisStorage.java 17.07% 26 Missing and 8 partials ⚠️
...java/org/swisspush/reststorage/RestStorageMod.java 50.00% 9 Missing ⚠️
...ge/exception/RestStorageNoStacktraceException.java 0.00% 9 Missing ⚠️
...ge/exception/RestStorageNoStackReplyException.java 0.00% 7 Missing ⚠️
...swisspush/reststorage/lock/lua/LuaScriptState.java 30.00% 4 Missing and 3 partials ⚠️
...ava/org/swisspush/reststorage/EventBusAdapter.java 40.00% 6 Missing ⚠️
...a/org/swisspush/reststorage/FileSystemStorage.java 25.00% 6 Missing ⚠️
.../exception/RestStorageThriftyExceptionFactory.java 28.57% 5 Missing ⚠️
...wisspush/reststorage/lock/impl/RedisBasedLock.java 37.50% 5 Missing ⚠️
.../org/swisspush/reststorage/RestStorageHandler.java 66.66% 3 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #186      +/-   ##
=============================================
- Coverage      62.65%   62.15%   -0.50%     
- Complexity       422      427       +5     
=============================================
  Files             35       40       +5     
  Lines           2702     2751      +49     
  Branches         310      304       -6     
=============================================
+ Hits            1693     1710      +17     
- Misses           845      882      +37     
+ Partials         164      159       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddenalpha hiddenalpha requested review from dominik-cnx and mcweba May 23, 2024 13:03
@hiddenalpha hiddenalpha merged commit f86cb21 into swisspost:develop May 24, 2024
1 check passed
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 24, 2024
OMG! What a conflict mess.

Conflicts:
      src/main/java/org/swisspush/redisques/QueueStatsService.java
      src/main/java/org/swisspush/redisques/RedisQues.java
      src/main/java/org/swisspush/redisques/action/GetQueuesItemsCountAction.java
      src/main/java/org/swisspush/redisques/handler/GetQueuesItemsCountHandler.java
      src/main/java/org/swisspush/redisques/handler/RedisquesHttpRequestHandler.java
      src/main/java/org/swisspush/redisques/util/QueueActionFactory.java
      src/main/java/org/swisspush/redisques/util/QueueStatisticsCollector.java

Related: SDCISA-15833, swisspost#170, swisspost#177, swisspost/vertx-rest-storage#186, swisspost/gateleen#577
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 24, 2024
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request May 24, 2024
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 24, 2024
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants