Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate code (again) #147

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Remove duplicate code (again) #147

merged 8 commits into from
Jan 26, 2024

Conversation

swissspidy
Copy link
Owner

No description provided.

@swissspidy swissspidy added the enhancement New feature or request label Jan 26, 2024
@swissspidy swissspidy added this to the 1.1.0 milestone Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (8ecab6b) 81.58% compared to head (a410224) 92.50%.

Files Patch % Lines
lib/class-performant-translations.php 68.29% 13 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #147       +/-   ##
=============================================
+ Coverage     81.58%   92.50%   +10.91%     
+ Complexity      235      221       -14     
=============================================
  Files             7        6        -1     
  Lines           554      520       -34     
=============================================
+ Hits            452      481       +29     
+ Misses          102       39       -63     
Flag Coverage Δ
default 54.42% <0.00%> (-27.17%) ⬇️
integration 40.57% <68.29%> (?)
multisite 40.57% <68.29%> (+7.72%) ⬆️
trunk 66.73% <68.29%> (?)
unit 54.42% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissspidy swissspidy merged commit 58ee6f1 into main Jan 26, 2024
17 of 18 checks passed
@swissspidy swissspidy deleted the fix/duplicate-code branch January 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant