Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RpcProvider->getList两次调用问题 #1076

Closed
xiaoproject opened this issue Nov 1, 2019 · 4 comments
Closed

RpcProvider->getList两次调用问题 #1076

xiaoproject opened this issue Nov 1, 2019 · 4 comments
Labels
bug: fixed bug fixed optimization suggestion swoft: rpc
Milestone
v2.0.7

Comments

@xiaoproject
Copy link

xiaoproject commented Nov 1, 2019 •
edited
Loading

Swoft\Rpc\Client\Connection

image

这样的话，每次去调用rpc方法的时候，App\Common\RpcProvider -> getList() 方法都会调用两次
可否修改为一下的方式
image
@inhere
Copy link
Member

inhere commented Nov 1, 2019 •
edited
Loading

@xiaoproject 感谢指出。有兴趣可以直接发 PR 帮助改进。

如何发PR以及注意，请看这里 #829

@stelin
Copy link
Member

stelin commented Nov 9, 2019

2.0.7 修复下，感谢支持swoft

@inhere inhere added this to the v2.0.7 milestone Nov 9, 2019
@stelin
Copy link
Member

stelin commented Nov 17, 2019

已修复 2.0.7发布

@stelin stelin added the bug: fixed bug fixed label Nov 17, 2019
@stelin
Copy link
Member

stelin commented Nov 18, 2019

2.0.7已发布，请更新

@stelin stelin closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: fixed bug fixed optimization suggestion swoft: rpc
Projects
None yet
Milestone
v2.0.7
Development

No branches or pull requests
3 participants
@stelin @inhere @xiaoproject