Tests

[daun]

Description

• Unit tests only
• For this plugin, we don't really need end-to-end tests
  • Unit-testing the helpers
  • Unit-testing the plugin to make sure it calls the helpers
  • That's about as good as messing with the whole end-to-end setup and much simpler :)

Checks

• The PR is submitted to the master branch
• The code was linted before pushing (npm run lint)
• All tests are passing (npm run test)
• New or updated tests are included
• The documentation was updated as required

[daun]

@hirasso Ready for review :)

[daun]

@hirasso Just realized this looks a bit chaotic from the diff view — I fell for the temptation of some refactoring 🤠 but most of it is related to making things testable or applying autoformatting.

[hirasso]

This is all all well over my head as I haven't ever looked into the source code of head plugin and haven't got the time to do so right now – that's why my comments are only small nitpicks. Sorry for not being of more help here, but tests are always better then no tests right? 😇

[hirasso]

@daun did you test the latest @swup/cli swup package:format with this, formatting the tests and readme.md additionally to the source code? 🙂

[daun]

@hirasso I think so?

[daun]

@hirasso Looks like that's what happened, but I don't remember 🤠

[hirasso]

🧪