Merge pull request #444 from creative-commoners/pulls/6/replace-exten…

…sion-subclasses API Replace Extension subclasses
symbiote · Aug 28, 2024 · feedb5f · feedb5f
2 parents ff6e224 + 9b370cb
commit feedb5f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/Extensions/MaintenanceLockExtension.php b/src/Extensions/MaintenanceLockExtension.php
@@ -4,7 +4,7 @@
 
 use SilverStripe\Forms\CheckboxField;
 use SilverStripe\Forms\FieldList;
-use SilverStripe\ORM\DataExtension;
+use SilverStripe\Core\Extension;
 use SilverStripe\SiteConfig\SiteConfig;
 use Symbiote\QueuedJobs\Services\QueuedJobService;
 
@@ -14,9 +14,9 @@
  *
  * @package Symbiote\QueuedJobs\Extensions
  *
- * @extends DataExtension<SiteConfig&static>
+ * @extends Extension<SiteConfig&static>
  */
-class MaintenanceLockExtension extends DataExtension
+class MaintenanceLockExtension extends Extension
 {
     /**
      * @param FieldList $fields

diff --git a/src/Extensions/ScheduledExecutionExtension.php b/src/Extensions/ScheduledExecutionExtension.php
@@ -9,7 +9,7 @@
 use SilverStripe\Forms\NumericField;
 use SilverStripe\Forms\ReadonlyField;
 use SilverStripe\Forms\TextField;
-use SilverStripe\ORM\DataExtension;
+use SilverStripe\Core\Extension;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use Symbiote\QueuedJobs\DataObjects\QueuedJobDescriptor;
@@ -27,9 +27,9 @@
  *
  * @method QueuedJobDescriptor ScheduledJob()
  *
- * @extends DataExtension<DataObject&static>
+ * @extends Extension<DataObject&static>
  */
-class ScheduledExecutionExtension extends DataExtension
+class ScheduledExecutionExtension extends Extension
 {
     /**
      * @var array
@@ -107,8 +107,6 @@ protected function updateCMSFields(FieldList $fields)
 
     protected function onBeforeWrite()
     {
-        parent::onBeforeWrite();
-
         if ($this->owner->FirstExecution) {
             $changed = $this->owner->getChangedFields();
             $changed = (