From fabf1613b08de3b42bfb8bebfd8c0fdf3765fcfd Mon Sep 17 00:00:00 2001 From: Jeremiah <4462211+jeremiahpslewis@users.noreply.github.com> Date: Tue, 12 Sep 2023 08:40:44 +0000 Subject: [PATCH 1/5] Add .devcontainer --- .devcontainer/Dockerfile | 5 +++++ .devcontainer/devcontainer.json | 7 +++++++ 2 files changed, 12 insertions(+) create mode 100644 .devcontainer/Dockerfile create mode 100644 .devcontainer/devcontainer.json diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile new file mode 100644 index 0000000..d97754c --- /dev/null +++ b/.devcontainer/Dockerfile @@ -0,0 +1,5 @@ +FROM julia:1.10-rc + +RUN apt-get update && apt-get install -y git + +RUN julia -e 'using Pkg; Pkg.activate("."); Pkg.instantiate()' diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json new file mode 100644 index 0000000..8329d86 --- /dev/null +++ b/.devcontainer/devcontainer.json @@ -0,0 +1,7 @@ +{ + "extensions": [ + "julialang.language-julia" + ], + "runArgs": ["--privileged"], + "dockerFile": "Dockerfile" +} From 8aff23e168c17c331def2fa786a337fc8beddd32 Mon Sep 17 00:00:00 2001 From: Jeremiah <4462211+jeremiahpslewis@users.noreply.github.com> Date: Tue, 12 Sep 2023 08:40:59 +0000 Subject: [PATCH 2/5] Bump SymEngine to v0.10 --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 8673272..33cb40d 100644 --- a/Project.toml +++ b/Project.toml @@ -15,7 +15,7 @@ SymEngine_jll = "3428059b-622b-5399-b16f-d347a77089a4" Compat = "0.63.0, 1, 2, 3, 4" RecipesBase = "0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 1.0" SpecialFunctions = "0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 1, 2" -SymEngine_jll = "0.9" +SymEngine_jll = "0.9, 0.10" julia = "1.6" [extras] From 7ffdb5f6f3c8eb393ba27071e7d694ff6082d4cf Mon Sep 17 00:00:00 2001 From: Jeremiah <4462211+jeremiahpslewis@users.noreply.github.com> Date: Tue, 12 Sep 2023 08:53:05 +0000 Subject: [PATCH 3/5] Fix methoderror / ambiguous type signature --- src/mathfuns.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mathfuns.jl b/src/mathfuns.jl index 85ceb52..72e30a9 100644 --- a/src/mathfuns.jl +++ b/src/mathfuns.jl @@ -98,6 +98,7 @@ for (meth, libnm) in [(:gcd, :gcd), end Base.binomial(n::Basic, k::Number) = binomial(N(n), N(k)) #ntheory_binomial seems wrong +Base.binomial(n::Basic, k::Integer) = binomial(N(n), N(k)) #Fix dispatch ambiguity / MethodError Base.rem(a::SymbolicType, b::SymbolicType) = a - (a รท b) * b Base.factorial(n::SymbolicType, k) = factorial(N(n), N(k)) From 9bc6d48013dc7ed6c5a13133dd8189116a46f08d Mon Sep 17 00:00:00 2001 From: Jeremiah <4462211+jeremiahpslewis@users.noreply.github.com> Date: Tue, 12 Sep 2023 10:54:30 +0200 Subject: [PATCH 4/5] Version bump --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 33cb40d..d71b5f3 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "SymEngine" uuid = "123dc426-2d89-5057-bbad-38513e3affd8" -version = "0.9.1" +version = "0.10.0" [deps] Compat = "34da2185-b29b-5c13-b0c7-acf172513d20" From 6b556004fd118d890b8c6cd2ac0c3b3f56b8b298 Mon Sep 17 00:00:00 2001 From: Jeremiah <4462211+jeremiahpslewis@users.noreply.github.com> Date: Tue, 12 Sep 2023 10:59:28 +0200 Subject: [PATCH 5/5] Drop non-functional badges --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index b30edae..81019d2 100644 --- a/README.md +++ b/README.md @@ -5,9 +5,6 @@ [![Codecov](http://codecov.io/github/symengine/SymEngine.jl/coverage.svg?branch=master)](http://codecov.io/github/symengine/SymEngine.jl?branch=master) [![Coveralls](https://coveralls.io/repos/symengine/SymEngine.jl/badge.svg?branch=master&service=github)](https://coveralls.io/github/symengine/SymEngine.jl?branch=master) -[![SymEngine](http://pkg.julialang.org/badges/SymEngine_0.6.svg)](http://pkg.julialang.org/?pkg=SymEngine) -[![SymEngine](http://pkg.julialang.org/badges/SymEngine_0.7.svg)](http://pkg.julialang.org/?pkg=SymEngine) - Julia Wrappers for [SymEngine](https://github.com/symengine/symengine), a fast symbolic manipulation library, written in C++. ## Installation