Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic utils extension #265

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Conversation

jverzani
Copy link
Contributor

This PR adds an extension for SymbolicUtils. With this loaded, the rewriting rules of SymbolicUtils can be used, which should expand the feature set of SymEngine.jl.

julia> using SymEngine, SymbolicUtils
@
julia> @vars x y
(x, y)

julia> simplify(sin(x)^2 + cos(x)^2)
1

@jverzani jverzani mentioned this pull request Sep 12, 2023
@isuruf
Copy link
Member

isuruf commented Sep 13, 2023

Looks good. Can you add some tests?

@jverzani
Copy link
Contributor Author

Ok, borrowed examples from https://symbolicutils.juliasymbolics.org/rewrite/#rule-based_rewriting to do so.

@isuruf isuruf merged commit 71c1e71 into symengine:master Sep 14, 2023
9 of 10 checks passed
@isuruf
Copy link
Member

isuruf commented Sep 14, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants